Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Meteor methods and client cart code #5059

Merged
merged 5 commits into from Mar 25, 2019

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Mar 21, 2019

Impact: minor
Type: feature

Changes

  • Removed Meteor methods that are no longer needed due to removal of storefront from this UI codebase
  • Removed client code that is no longer needed due to removal of storefront from this UI codebase

Breaking changes

Any custom plugins relying on the removed Meteor methods will need to be updated.

Testing

Verify that operator UI renders without any errors and key operator actions work properly.

Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed aldeed self-assigned this Mar 21, 2019
@aldeed aldeed added this to the 🏔 Uncompahgre milestone Mar 21, 2019
@aldeed aldeed marked this pull request as ready for review March 21, 2019 19:26
@aldeed aldeed requested a review from mikemurray March 21, 2019 19:26
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikemurray mikemurray merged commit 4c8ead1 into develop Mar 25, 2019
@mikemurray mikemurray deleted the feat-aldeed-remove-unused-methods branch March 25, 2019 17:09
@jeffcorpuz jeffcorpuz mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants