Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix all max-len eslint warnings #5296

Merged
merged 2 commits into from Jul 9, 2019
Merged

chore: fix all max-len eslint warnings #5296

merged 2 commits into from Jul 9, 2019

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Jul 9, 2019 •
edited

Resolves #5270
Impact: minor
Type: chore

Issue

We currently have ~200 max-len eslint warnings.

Solution

Fix (or disable) these warnings, and then update our eslint rules to make max-len an error so new violations are not introduced.

The errors are fixed in most places, and disabled in email template files.

Updated rules: reactioncommerce/reaction-eslint-config#11

Breaking changes

None.

Testing

  1. run eslint
  2. see there are no longer any max-len warnings (and no errors)

@kieckhafer kieckhafer mentioned this pull request Jul 9, 2019
Merged
@kieckhafer
fix max-len issues
20473cb 
Signed-off-by: Erik Kieckhafer <ek@ato.la>
@kieckhafer kieckhafer added this to Review in progress in eslint audit Jul 9, 2019
eslint audit automation moved this from Review in progress to Reviewer approved Jul 9, 2019
@kieckhafer kieckhafer merged commit d672217 into develop Jul 9, 2019
eslint audit automation moved this from Reviewer approved to Done Jul 9, 2019
@kieckhafer kieckhafer deleted the chore-kieckhafer-eslintAudit-maxLen branch July 9, 2019 22:27
@kieckhafer kieckhafer mentioned this pull request Jul 9, 2019
Closed
@kieckhafer kieckhafer restored the chore-kieckhafer-eslintAudit-maxLen branch July 10, 2019 04:59
@kieckhafer kieckhafer deleted the chore-kieckhafer-eslintAudit-maxLen branch July 10, 2019 05:01
@kieckhafer kieckhafer mentioned this pull request Aug 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosshadden rosshadden rosshadden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
eslint audit
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kieckhafer @rosshadden