Fix problems with accounts queries #6060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Filtering by shop ID is no longer possible because accounts do not belong to any one shop. Filtering by one or more account groups is now possible. All accounts are returned, and not just non-admins. Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
fixes #5906 Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
It's optional, we no longer set it, and it doesn't mean anything Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
to silent ES module warning Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
kieckhafer
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Looks good overall.
Came across one issue that seems to maybe stem from the api-utils, not this PR. I've created a ticket for that issue, and also made a change in this PR to fix the issue for now.
This was referenced Jan 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6006
Resolves #5906
Resolves #6017
Impact: minor
Type: feature|bugfix
Changes
accountsGQL query returning only non-admin accounts and requiringshopIdparam for a filter, it now returns all accounts and accepts an optionalgroupIdsarray for filtering. You can't filter byshopIdbecause this no longer makes sense; accounts do not belong to a particular shop in 3.0.shopIdparamsAccount.groupswas alwaysnullwhen requested through GraphQL. Now it's correct.account.shopId, which isn't usually set anymore.cjsextension on.eslintrcfile, and then changed that extension. This silences a warning that was showing when running lint command.Breaking changes
The
accountsGQL query takes different params and returns different results as described above.Testing
Run GQL queries to verify the changes. I've updated the relevant integration tests, too.