Improved CI Config Stability #49
Conversation
reactive-firewall
commented
Sep 21, 2017
reactive-firewall
commented
- Improves the stablitity of the CI configurations
- releases blocked features from version 0.2.8
- bump version to 0.2.9
- added stable circle-CI config and other QA integrations for the development work-flow
- due to overwhelming burden caused by xcode6.4 support xcode6.4 support has been dropped
tests/check_spelling
Outdated
| THE_TEMP_FILE=/tmp/swapfile_spellcheck_$RANDOM.tmp.txt | ||
| (spellintian ${@:-./**/*} 2>/dev/null | fgrep " -> " ) & (spellintian ${@:-./*} 2>/dev/null | fgrep " -> " ) & (spellintian ${@:-./**/**/*} 2>/dev/null | fgrep " -> " ) | sort -h | uniq | tee -a ${THE_TEMP_FILE:-/dev/null} | ||
| wait ; | ||
| THECOUNT=$((wc -l ${THE_TEMP_FILE} 2>/dev/null || echo 0 )| cut -d\ -f 1 ) |
There was a problem hiding this comment.
Couldn't parse this $((..)) expression.
The mentioned parser error was in this $((..)) expression.
Expected "))". Fix any mentioned problems and try again.
|
Stickler CI failed to correctly parse balanced parenthesis This issue will cause more delays due to degraded build times on CI |
tests/check_spelling
Outdated
| #! /bin/bash | ||
|
|
||
| THE_TEMP_FILE=/tmp/swapfile_spellcheck_$RANDOM.tmp.txt | ||
| (spellintian ${@:-./**/*} 2>/dev/null | fgrep " -> " ) & (spellintian ${@:-./*} 2>/dev/null | fgrep " -> " ) & (spellintian ${@:-./**/**/*} 2>/dev/null | fgrep " -> " ) | sort -h | uniq | tee -a ${THE_TEMP_FILE:-/dev/null} |
There was a problem hiding this comment.
Double quote array expansions, otherwise they're like $* and break on spaces.
| #! /bin/bash | ||
|
|
||
| # exit fast if command is missing | ||
| test -x $(which spellintian) || exit 0 ; |
There was a problem hiding this comment.
Quote this to prevent word splitting.
| test -x $(which spellintian) || exit 0 ; | ||
|
|
||
| THE_TEMP_FILE="/tmp/swapfile_spellcheck_${RANDOM}.tmp.txt" ; | ||
| ( (spellintian ${@:-./**/*} 2>/dev/null | fgrep " -> ") & (spellintian ${@:-./*} 2>/dev/null | fgrep " -> ") & (spellintian ${@:-./**/**/*} 2>/dev/null | fgrep " -> ") ) | sort -h | uniq | tee -a ${THE_TEMP_FILE:-/dev/null} ; |
There was a problem hiding this comment.
Double quote array expansions, otherwise they're like $* and break on spaces.
Codecov Report
@@ Coverage Diff @@
## stable #49 +/- ##
==========================================
- Coverage 89.12% 87.09% -2.03%
==========================================
Files 28 28
Lines 2317 2317
==========================================
- Hits 2065 2018 -47
- Misses 252 299 +47
Continue to review full report at Codecov.
|
1 similar comment
