enhance: Block dispatches after unmount #2307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntucker
force-pushed
the
enhance/dispatch-safety
branch
from
6c75bee to
7766825
Compare
ntucker
force-pushed
the
enhance/dispatch-safety
branch
from
7766825 to
41047e6
Compare
notwillk
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
User-land managers might call dispatchers after unmount. Forcing users to think about this is unnecessary complexity and learning curve.
Solution
Simply ignore them. In dev mode we will log at debug level as this is not considered a bug. But it may be useful if one is expecting dispatches to know where they went.