Inifinite loop in the DateTime resolvers.

[glennawatson]

My pr introduced a bug showing an infinite loop of calls exhausting the stack:
edit: it's not my pr, it's your code lol :)
edit2: it's not my pr, it's not your code. It's when an existingContractResolver is non null and derives from DefaultContractResolver. Then it loops ...

Originally posted by @softlion in #459 (comment)

Newtonsoft_Json_Utilities_ThreadSafeStore_2_TKey_REF_TValue_REF_Get_TKey_REF + 29119496 (ThreadSafeStore.cs:64)
Newtonsoft_Json_Serialization_DefaultContractResolver_ResolveContract_System_Type + 29123632 (DefaultContractResolver.cs:198)
Akavache_JsonDateTimeContractResolver_CreateContract_System_Type + 38540100 (/D:\a\1\s\src\Akavache.Core\JsonDateTimeContractResolver.cs:23)
System_Collections_Concurrent_ConcurrentDictionary_2_TKey_REF_TValue_REF_GetOrAdd_TKey_REF_System_Func_2_TKey_REF_TValue_REF + 180
Newtonsoft_Json_Utilities_ThreadSafeStore_2_TKey_REF_TValue_REF_Get_TKey_REF + 29119496 (ThreadSafeStore.cs:64)
Newtonsoft_Json_Serialization_DefaultContractResolver_ResolveContract_System_Type + 29123632 (DefaultContractResolver.cs:198)
Akavache_JsonDateTimeContractResolver_CreateContract_System_Type + 38540100 (/D:\a\1\s\src\Akavache.Core\JsonDateTimeContractResolver.cs:23)
System_Collections_Concurrent_ConcurrentDictionary_2_TKey_REF_TValue_REF_GetOrAdd_TKey_REF_System_Func_2_TKey_REF_TValue_REF + 180
Newtonsoft_Json_Utilities_ThreadSafeStore_2_TKey_REF_TValue_REF_Get_TKey_REF + 29119496 (ThreadSafeStore.cs:64)
Newtonsoft_Json_Serialization_DefaultContractResolver_ResolveContract_System_Type + 29123632 (DefaultContractResolver.cs:198)
Akavache_JsonDateTimeContractResolver_CreateContract_System_Type + 38540100 (/D:\a\1\s\src\Akavache.Core\JsonDateTimeContractResolver.cs:23)
System_Collections_Concurrent_ConcurrentDictionary_2_TKey_REF_TValue_REF_GetOrAdd_TKey_REF_System_Func_2_TKey_REF_TValue_REF + 180
Newtonsoft_Json_Utilities_ThreadSafeStore_2_TKey_REF_TValue_REF_Get_TKey_REF + 29119496 (ThreadSafeStore.cs:64)
Newtonsoft_Json_Serialization_DefaultContractResolver_ResolveContract_System_Type + 29123632 (DefaultContractResolver.cs:198)
Akavache_JsonDateTimeContractResolver_CreateContract_System_Type + 38540100 (/D:\a\1\s\src\Akavache.Core\JsonDateTimeContractResolver.cs:23)
System_Collections_Concurrent_ConcurrentDictionary_2_TKey_REF_TValue_REF_GetOrAdd_TKey_REF_System_Func_2_TKey_REF_TValue_REF + 180
Newtonsoft_Json_Utilities_ThreadSafeStore_2_TKey_REF_TValue_REF_Get_TKey_REF + 29119496 (ThreadSafeStore.cs:64)```

[glennawatson]

This is related to a issue that @softlion brought up in #459

[glennawatson]

I think the easy solution is to check if the resolver is derived from the DefaultContractResolver to prevent the re-entry. I won't realistically get it to later this week so if you get a PR in before then I will merge as soon as I see it.

[softlion]

should be resolved in #465

I can't reproduce the loop in unit tests. but i can in the real app (randomly -often enough- though).

[softlion]

Plz merge and post nuget as soon as you can, its very urgent ;)

[open-collective-bot]

Hey 👋,

We saw you use our package. To keep our code as accessible as possible, we decided to open source it and are now helping others with their questions.

In a pursuit to continue our work, help us by donating to our collective! ❤️

https://opencollective.com/reactiveui

ReactiveUI - Open Collective

An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms!