[feature] Clean warnings #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validations-3 * master: Added comments on the iOS project following rule sets. Added comments and reordered code following analyzers rules. Added reference to Directory props from the src folder. Update directory.build.props # Conflicts: # LICENSE
…ation for BasePropertyValidation classes.
…elObservableValidation.
…ments for ValidationContext.
…roved some LINQ queries too.
….Forms sample. (#5)
# Conflicts: # src/ReactiveUI.Validation/Contexts/ValidationContext.cs
|
Looks good! By the way seeing a lot of commits unrelated to this PR. Those commits seem to be already merged to master, is there any chance to get rid of them (probably via rebase or force-pushing this particular branch)? |
|
I think the fastest way Todo that would be to re clone the repo and paste these changes in from a backup copy. |
|
Those commits are from my last PR, which are not affecting the current PR's goal. So, how should we proceed with this PR now? |
|
Handling in #13 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue: #10