New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InvokeCommand targets ReactiveCommandBase, not ReactiveCommand #1235

Closed
kentcb opened this Issue Jan 20, 2017 · 0 comments

Comments

Projects
None yet
3 participants
@kentcb
Copy link
Contributor

kentcb commented Jan 20, 2017

Note: for support questions, please ask on StackOverflow: https://stackoverflow.com/questions/tagged/reactiveui . This repository's issues are reserved for feature requests and bug reports.

Do you want to request a feature or report a bug?

Bug/design deficiency.

What is the current behavior?

The relevant InvokeCommand extensions extend ReactiveCommand<TParam, TResult>.

What is the expected behavior?

The relevant InvokeCommand extensions should extend ReactiveCommandBase<TParam, TResult>, allowing you to use InvokeCommand against other reactive commands, such as CombinedReactiveCommand.

What is the motivation / use case for changing the behavior?

Better, more flexible design.

Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and snapshot (http://docs.reactiveui.net/en/contributing/snapshot/index.html) versions.

7

@kentcb kentcb added the help wanted label Jan 20, 2017

@kentcb kentcb added this to the vNext milestone Jan 30, 2017

@kentcb kentcb changed the title InvokeCommand should target ReactiveCommandBase, not ReactiveCommand fix: InvokeCommand targets ReactiveCommandBase, not ReactiveCommand Jan 30, 2017

@kentcb kentcb closed this in #1241 Jan 30, 2017

kentcb added a commit that referenced this issue Jan 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment