New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove superfluous AsObservable calls in ReactiveCommand #1236

Closed
kentcb opened this Issue Jan 21, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@kentcb
Copy link
Contributor

kentcb commented Jan 21, 2017

Do you want to request a feature or report a bug?

Code issue.

What is the current behavior?

ReactiveCommand includes several properties that return observables, but calls AsObservable on those return values.

What is the expected behavior?

There is no need to call AsObservable - it only adds to the performance cost by creating another object on top of the already-usable observable.

What is the motivation / use case for changing the behavior?

Better code and performance.

Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and snapshot (http://docs.reactiveui.net/en/contributing/snapshot/index.html) versions.

7

@kentcb kentcb self-assigned this Jan 25, 2017

@kentcb kentcb added this to the vNext milestone Jan 30, 2017

@kentcb kentcb changed the title Superfluous AsObservable calls in ReactiveCommand perf: remove superfluous AsObservable calls in ReactiveCommand Jan 30, 2017

@kentcb kentcb closed this in #1240 Jan 30, 2017

kentcb added a commit that referenced this issue Jan 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment