Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: complete command execution only when pipeline completes #1244
Do you want to request a feature or report a bug?
What is the current behavior?
A reactive command's execution completes whenever a value ticks.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
Create a command that ticks multiple values:
var ticks = Observable.Timer(TimeSpan.Zero, TimeSpan.FromSeconds(1)).Take(3); var command = ReactiveCommand.CreateFromObservable(ticks);
When you execute the command, you'll see its
What is the expected behavior?
An execution pipeline should complete before the command becomes available again.
What is the motivation / use case for changing the behavior?
Erroneous behavior. Ticking multiple values can be useful in certain circumstances (such as reporting progress throughout execution).
Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and snapshot (http://docs.reactiveui.net/en/contributing/snapshot/index.html) versions.