New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch exceptions from InvokeCommand #1247

Closed
kentcb opened this Issue Jan 28, 2017 · 0 comments

Comments

Projects
None yet
3 participants
@kentcb
Copy link
Contributor

kentcb commented Jan 28, 2017

Do you want to request a feature or report a bug?

Bug.

What is the current behavior?

InvokeCommand does not catch exceptions, making it useless for any scenario where an exception might be thrown by the target command.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

someObservable
    .InvokeCommand(someCommandThatCanError);

This code is a time-bomb. When someCommandThatCanError throws, the pipeline established by InvokeCommand will error.

What is the expected behavior?

Exceptions should be caught and silently swallowed by InvokeCommand. This won't prevent them from bubbling through ThrownExceptions as desired.

It's worth pointing out this was the original behavior of InvokeCommand and it got lost in the rewrite of reactive commands (totally my bad. Again).

What is the motivation / use case for changing the behavior?

Make InvokeCommand Great Again!

Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and snapshot (http://docs.reactiveui.net/en/contributing/snapshot/index.html) versions.

7

@kentcb kentcb self-assigned this Jan 28, 2017

@kentcb kentcb added reactiveui-core and removed in progress labels Jan 30, 2017

@kentcb kentcb added this to the vNext milestone Jan 30, 2017

@kentcb kentcb changed the title InvokeCommand should catch exceptions fix: catch exceptions from InvokeCommand Jan 30, 2017

@kentcb kentcb closed this in #1248 Jan 30, 2017

kentcb added a commit that referenced this issue Jan 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment