Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Fody ToPropertyEx work against IReactiveObject #2248

Open
MartinZikmund opened this issue Nov 17, 2019 · 8 comments
Open

Make Fody ToPropertyEx work against IReactiveObject #2248

MartinZikmund opened this issue Nov 17, 2019 · 8 comments

Comments

@MartinZikmund
Copy link

Is your feature request related to a problem? Please describe.

I would like to use ToPropertyEx against an instance of IReactiveObject, but it unfortunately requires a ReactiveObject

Describe the solution you'd like

Change the generic constraint on ToPropertyEx to class, IReactiveObject to match ToProperty method.

Describe alternatives you've considered

Implementing the method manually, but that is less convenient that having this out of the box.

Describe suggestions on how to achieve the feature

Change the generic constraint on ToPropertyEx to class, IReactiveObject to match ToProperty method. Unfortunately this causes failure of API approval test. The change makes the constraint more permissive, but it is still a breaking change.

@open-collective-bot
Copy link

open-collective-bot bot commented Nov 17, 2019

Hey @MartinZikmund 👋,

Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider contributing financially.

https://opencollective.com/reactiveui

PS.: We offer priority support for all financial contributors. Don't forget to add priority label once you start contributing 😄

An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms!

@MartinZikmund
Copy link
Author

If we agree on a way to resolve this, I would love to contribute the change

@cabauman
Copy link
Contributor

@glennawatson shall we consider this request at the same time as changing the ToPropertyEx name?

@glennawatson
Copy link
Contributor

Yeah. I have this happening in my testing version.

@glennawatson glennawatson self-assigned this Aug 31, 2020
@jcummings2
Copy link
Contributor

Any update on this capability?

@glennawatson
Copy link
Contributor

Next major release is the plan for this one. There is a major rewrite for the Fody coming up that will support these features.

@glennawatson
Copy link
Contributor

The fody is going into maintenance-only mode at the moment while we work on a new project which will replace the functionality in general. Keeping this open to track for the new project.

@jcummings2
Copy link
Contributor

By maintenance-only mode, I presume that's in reference to everyone-should-be-a-fody-patron.

Where is the new project and how can we contribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants