Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: mintarget is no longer 460 as 452 is still supported #1195

Merged
merged 1 commit into from Nov 7, 2016

Conversation

ghuntley
Copy link
Member

@ghuntley ghuntley commented Nov 7, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Revert of 9738872

What is the current behavior? (You can also link to an open issue here)

In #1184 I bumped the min supported framework from NET45 to NET46 due to misunderstanding the support-life-cycle of NET452. It's cousins 450/451 have been EOL'ed but NET452 will be around for quite some time to come.

What is the new behavior (if this is a feature change)?

Reverts the changes in #1184 and lowers min framework to NET452

This is important as the default framework used in Visual Studio 2015 when creating a class library is still 452. Staying at 460 would have resulted in friction for our users and a common source of github issues whereby the resolution would always be asking our users to retarget their unit test assemblies to 460

Does this PR introduce a breaking change?

The net460 retarget was never published to NuGet.org.

Please check if the PR fulfills these requirements

Other information:

This reverts commit 9738872.

@ghuntley ghuntley merged commit 4a82e07 into develop Nov 7, 2016
@ghuntley ghuntley deleted the use-net452-as-min-target branch November 7, 2016 11:53
glennawatson pushed a commit that referenced this pull request Mar 23, 2019
@lock lock bot locked and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant