revert: mintarget is no longer 460 as 452 is still supported #1195

Merged
merged 1 commit into from Nov 7, 2016

Projects

None yet

1 participant

@ghuntley
Member
ghuntley commented Nov 7, 2016 edited

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Revert of 9738872

What is the current behavior? (You can also link to an open issue here)

In #1184 I bumped the min supported framework from NET45 to NET46 due to misunderstanding the support-life-cycle of NET452. It's cousins 450/451 have been EOL'ed but NET452 will be around for quite some time to come.

What is the new behavior (if this is a feature change)?

Reverts the changes in #1184 and lowers min framework to NET452

This is important as the default framework used in Visual Studio 2015 when creating a class library is still 452. Staying at 460 would have resulted in friction for our users and a common source of github issues whereby the resolution would always be asking our users to retarget their unit test assemblies to 460

Does this PR introduce a breaking change?

The net460 retarget was never published to NuGet.org.

Please check if the PR fulfills these requirements

Other information:

This reverts commit 9738872.

@ghuntley ghuntley revert: mintarget is no longer 460 as 452 is still supported
This reverts commit 9738872.
24082c0
@ghuntley ghuntley added the in progress label Nov 7, 2016
@ghuntley ghuntley merged commit 4a82e07 into develop Nov 7, 2016

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ghuntley ghuntley deleted the use-net452-as-min-target branch Nov 7, 2016
@ghuntley ghuntley removed the in progress label Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment