New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: added generic reactive controllers and views for iOS and Mac #1216

Merged
merged 3 commits into from Jan 9, 2017

Conversation

Projects
None yet
3 participants
@Qonstrukt
Member

Qonstrukt commented Dec 12, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
I've added generic versions of every Reactive ViewController and View / Control on iOS and Mac to allow easier assignment of ViewModels with such classes.
We use these classes in all of our projects, and it's kind of cumbersome to copy them every time, or to create a special package.

It's also spoken of in #1029.

What is the current behavior? (You can also link to an open issue here)
You have to create/add these versions to all of your projects.

What is the new behavior (if this is a feature change)?
They're factory-installed!

Does this PR introduce a breaking change?
It shouldn't, since the non-generic versions are still there. I took the liberty of cleaning up unused usings though. But this is a case of "If it builds, it works."

Please check if the PR fulfills these requirements

Other information:

@ghuntley

This comment has been minimized.

Show comment
Hide comment
@ghuntley

ghuntley Jan 4, 2017

Member

@reactiveui/reviewers-ios and @reactiveui/reviewers-mac could you please have an 👁 of this for inclusion into ReactiveUI v7.1.0 (tomorrow?)

Member

ghuntley commented Jan 4, 2017

@reactiveui/reviewers-ios and @reactiveui/reviewers-mac could you please have an 👁 of this for inclusion into ReactiveUI v7.1.0 (tomorrow?)

@kentcb

This comment has been minimized.

Show comment
Hide comment
@kentcb

kentcb Jan 7, 2017

Contributor

lgtm. Thanks @Qonstrukt!

Contributor

kentcb commented Jan 7, 2017

lgtm. Thanks @Qonstrukt!

@ghuntley ghuntley added this to the 7-vNext milestone Jan 9, 2017

@ghuntley ghuntley changed the title from Added generic versions of iOS controller and views to feature: added generic reactive controllers and views for iOS and Mac Jan 9, 2017

@ghuntley ghuntley merged commit 0a97939 into reactiveui:develop Jan 9, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ghuntley ghuntley removed the xamarin-mac label Jan 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment