Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: reactiveui packages should be pinned and only work with packages from the same release #1225
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
The packages are unpinned;
What is the new behavior (if this is a feature change)?
The packages are now pinned;
Does this PR introduce a breaking change?
No, even if it did we don't want to support this behaviour. For maintainer sanity, we version ReactiveUI and package as a pinned group - all packages in a release will always be the same version and only work with that version which makes it impossible for a consumer to run into situations where they use reactiveui-core at 7.1.0 but reactiveui-xamforms at 7.0.0. Additionally all assemblies share the same CommonAssemblyInfo.cs which is updated just before compile time by the build infrastructure.
Please check if the PR fulfills these requirements
Thankyou @martijn00 for spotting this.