fix: reactiveui packages should be pinned and only work with packages from the same release #1225

Merged
merged 1 commit into from Jan 12, 2017

Projects

None yet

2 participants

@ghuntley
Member

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix.

What is the current behavior? (You can also link to an open issue here)

The packages are unpinned; version="$version$" means "Minimum version, inclusive" as per https://docs.nuget.org/ndocs/create-packages/dependency-versions

What is the new behavior (if this is a feature change)?

The packages are now pinned; version="[$version$]" means "Exact version match" as per https://docs.nuget.org/ndocs/create-packages/dependency-versions

Does this PR introduce a breaking change?

No, even if it did we don't want to support this behaviour. For maintainer sanity, we version ReactiveUI and package as a pinned group - all packages in a release will always be the same version and only work with that version which makes it impossible for a consumer to run into situations where they use reactiveui-core at 7.1.0 but reactiveui-xamforms at 7.0.0. Additionally all assemblies share the same CommonAssemblyInfo.cs which is updated just before compile time by the build infrastructure.

Please check if the PR fulfills these requirements

https://docs.reactiveui.net/en/contributing/framework/semantic-versioning.html has been updated.

Other information:

Thankyou @martijn00 for spotting this.

@ghuntley ghuntley added this to the 7.1.0 milestone Jan 11, 2017
@ghuntley ghuntley closed this Jan 11, 2017
@ghuntley ghuntley removed the in progress label Jan 11, 2017
@ghuntley ghuntley fix: reactiveui packages should be pinned and only work with packages…
… from the same release

For maintainer sanity, we version ReactiveUI and package as a pinned group - all packages in a release will always be the same version and only work with that version which makes it impossible for a consumer to run into situations where they use reactiveui-core at 7.1.0 but reactiveui-xamforms at 7.0.0. Additionally all assemblies share the same CommonAssemblyInfo.cs which is updated just before compile time by the build infrastructure.
2914685
@ghuntley ghuntley reopened this Jan 11, 2017
@GiusepeCasagrande

Seems fine by me.

@ghuntley ghuntley closed this Jan 12, 2017
@ghuntley ghuntley deleted the pin-to-exact-version branch Jan 12, 2017
@ghuntley ghuntley removed the in progress label Jan 12, 2017
@ghuntley ghuntley restored the pin-to-exact-version branch Jan 12, 2017
@ghuntley ghuntley reopened this Jan 12, 2017
@GiusepeCasagrande GiusepeCasagrande merged commit b1e60d9 into develop Jan 12, 2017

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ghuntley ghuntley deleted the pin-to-exact-version branch Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment