New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed next-version definition #1238

Merged
merged 2 commits into from Jan 31, 2017

Conversation

Projects
None yet
2 participants
@ghuntley
Copy link
Member

ghuntley commented Jan 25, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Chore

What is the current behavior? (You can also link to an open issue here)

Was used during the phase between 6.5.0 and the introduction of CI in 7.0.0 to prevent confusion with our early adopters by forcing the develop
branch to calculate the next release of v7.0.0. Without this, the release was calculating v6.6.0 when there were already consumers/early adopters using builds with a hand-rolled v7.0.0 version.

What is the new behavior (if this is a feature change)?

This is house-keeping cleanup. This value is ignored because the current release version is higher than the value defined here.

Does this PR introduce a breaking change?

No

Please check if the PR fulfills these requirements

Other information:

https://gitversion.readthedocs.io/en/latest/more-info/version-sources/

chore: removed next-version definition
Was used during the phase between 6.5.0 and the introduction of CI in
7.0.0 to prevent confusion with our early adopters by forcing the   `develop`
branch to calculate the next release of v7.0.0. Without this, the release was
calculating v6.6.0 when there were already consumers/early adopters using
builds with a hand-rolled v7.0.0 version.

@ghuntley ghuntley added this to the vNext milestone Jan 25, 2017

@ghuntley ghuntley removed the in progress label Jan 25, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 31, 2017

Coverage Status

Coverage remained the same at 65.563% when pulling 91630ef on ghuntley-patch-1 into f3678ea on develop.

@ghuntley ghuntley merged commit 2b99033 into develop Jan 31, 2017

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 65.563%
Details

@ghuntley ghuntley deleted the ghuntley-patch-1 branch Jan 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment