New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename MobileLifecycle.cs to SuspensionHost.cs #1252

Merged
merged 4 commits into from Feb 5, 2017

Conversation

Projects
None yet
4 participants
@olevett
Copy link
Member

olevett commented Jan 30, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
File rename

What is the current behavior? (You can also link to an open issue here)
MobileLifecycle contains a class called SuspensionHost and some related helpers, without any reference to MobileLifecycle. This is covered under #1246

Please check if the PR fulfills these requirements

Other information:

@olevett

This comment has been minimized.

Copy link
Member Author

olevett commented Jan 30, 2017

@kentcb - as discussed previously, this isn't the safest of change, given the variety of affected files - I've got builds working locally and the CI one seems to behave, so I think I've covered off all the places that should be impacted.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 1, 2017

Coverage Status

Coverage remained the same at 65.563% when pulling 542c69d on olevett:#1246-renaming into e41af92 on reactiveui:develop.

@olevett

This comment has been minimized.

Copy link
Member Author

olevett commented Feb 1, 2017

So this build has failed with

Build with specified version already exists.

not sure quite what to do about that, but given the Coveralls build succeeded, I think it's an AppVeyor issue/something I did that broke AppVeyor...

@kentcb

This comment has been minimized.

Copy link
Contributor

kentcb commented Feb 1, 2017

Hey @olevett. Yeah, I was trying to get this merged when things went awry. @ghuntley is looking into this.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 4, 2017

Coverage Status

Coverage remained the same at 65.574% when pulling d7264cf on olevett:#1246-renaming into 817dcce on reactiveui:develop.

@ghuntley

This comment has been minimized.

Copy link
Member

ghuntley commented Feb 4, 2017

Alright that build error has been resolved.

@kentcb kentcb changed the title #1246 renaming chore: rename MobileLifecycle.cs to SuspensionHost.cs Feb 5, 2017

@kentcb kentcb added this to the vNext milestone Feb 5, 2017

@kentcb kentcb added housekeeping and removed in progress labels Feb 5, 2017

@kentcb kentcb merged commit a7c7f9c into reactiveui:develop Feb 5, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 65.574%
Details
@kentcb

This comment has been minimized.

Copy link
Contributor

kentcb commented Feb 5, 2017

Thanks @ghuntley. And thanks for the PR @olevett!

@olevett olevett deleted the olevett:#1246-renaming branch Feb 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment