New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolved gitlink wasn't working because pdbs/xml were not included because of a packaging defect #1257

Merged
merged 5 commits into from Feb 2, 2017

Conversation

Projects
None yet
3 participants
@PureWeen
Copy link
Contributor

PureWeen commented Feb 2, 2017

… its magic

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix

What is the current behavior? (You can also link to an open issue here)
pdb and xml files aren't included in the nuspec

What is the new behavior (if this is a feature change)?
pdb and xml files are now included by the nuspec so that GitLink works

Does this PR introduce a breaking change?
It shouldn't. I was able to run build.cmd locally and install said packages with out any issues. Was also able to source step successfully!!!!

Please check if the PR fulfills these requirements

Other information:

Resolves #1254

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 2, 2017

Coverage Status

Coverage remained the same at 65.563% when pulling 4a7172b on PureWeen:1254_added_pdb_xml_to_nuspec_files_for_gitlink into e41af92 on reactiveui:develop.

ghuntley added some commits Feb 2, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 2, 2017

Coverage Status

Coverage remained the same at 65.563% when pulling e6a2a10 on PureWeen:1254_added_pdb_xml_to_nuspec_files_for_gitlink into e41af92 on reactiveui:develop.

@ghuntley ghuntley merged commit baab571 into reactiveui:develop Feb 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 65.563%
Details

@ghuntley ghuntley changed the title Added pdb and xml to the files markup of the nuspec so GitLink can do… chore: resolved gitlink wasn't working because pdbs/xml were not included because of a packaging defect Feb 2, 2017

@ghuntley ghuntley added this to the vNext milestone Feb 2, 2017

@ghuntley

This comment has been minimized.

Copy link
Member

ghuntley commented Feb 2, 2017

Thanks for the PR @PureWeen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment