Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upchore: failing to set the appveyor version should not be a fatal build error #1263
Conversation
ghuntley
added some commits
Jan 31, 2017
ghuntley
added
the
housekeeping
label
Feb 4, 2017
ghuntley
added this to the vNext milestone
Feb 4, 2017
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Feb 4, 2017
ghuntley
merged commit 817dcce
into
develop
Feb 4, 2017
ghuntley
deleted the
issue-1262
branch
Feb 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ghuntley commentedFeb 4, 2017
•
edited
Do you want to request a feature or report a bug?
chore/bug
What is the current behaviour?
When a build starts, the initial identifier is an auto-incremented value supplied by AppVeyor. As part of the build script, this version in AppVeyor is changed to be the version obtained from GitVersion. This identifier is purely cosmetic and is used by the core team to correlate a build with the pull-request.
In some circumstances, such as restarting a failed/cancelled build the identifier in AppVeyor will be already updated and default behaviour is to throw an exception/cancel the build when in fact it is safe to swallow or append additional metadata (like the epoch when the build was started)
What is the expected behavior?
This throwing should not be a fatal build error https://github.com/reactiveui/ReactiveUI/blob/develop/build.cake#L289.
Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and snapshot (http://docs.reactiveui.net/en/contributing/snapshot/index.html) versions.
v7.1.0
Other information (e.g. stacktraces, related issues, suggestions how to fix)
This is the root cause of the build problems experienced at #1252 - once this has been merged, update that PR via the update branch button and it will work again.