New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add UseInvariantCultureAttribute and apply to relevant tests #1283

Merged
merged 2 commits into from Feb 21, 2017

Conversation

Projects
None yet
3 participants
@b-straub
Copy link
Contributor

b-straub commented Feb 20, 2017

feat:, style: add an XUnit attribute to allow test running on invariant culture, this will avoid failed tests because of e.g. decimal separator differences

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature to prevent failed tests because of culture dependent decimal separators

What is the current behavior? (You can also link to an open issue here)

TwoWayBindWithFuncConvertersSmokeTest will fail on German locale

What is the new behavior (if this is a feature change)?

TwoWayBindWithFuncConvertersSmokeTest will succeed on German locale

Does this PR introduce a breaking change?

No!

Please check if the PR fulfills these requirements

[Fact, UseInvariantCulture]
TwoWayBindWithFuncConvertersSmokeTest

  • Docs have been added / updated (for bug fixes / features)

Other information:

Rebracer restyled existing code from Utility.cs no other modifications haven been applied

bstraub
feat:, style: add an XUnit attribute to allow test running on invaria…
…nt culture, this will avoid failed tests because of e.g. decimal separator differences
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 20, 2017

Coverage Status

Coverage remained the same at 66.688% when pulling 03d8f6e on b-straub:testingCulture into d9d36e5 on reactiveui:develop.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 21, 2017

Coverage Status

Coverage remained the same at 66.688% when pulling fa533d7 on b-straub:testingCulture into 823298d on reactiveui:develop.

@kentcb kentcb changed the title added an XUnit attribute UseInvariantCulture fix: add UseInvariantCultureAttribute and apply to relevant tests Feb 21, 2017

@kentcb kentcb added this to the vNext milestone Feb 21, 2017

@kentcb kentcb merged commit 0aab219 into reactiveui:develop Feb 21, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 66.688%
Details
@kentcb

This comment has been minimized.

Copy link
Contributor

kentcb commented Feb 21, 2017

Great stuff @b-straub - thanks!

@b-straub b-straub deleted the b-straub:testingCulture branch Feb 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment