Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: use netstandard 2.0 compatible version of splat #1579
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Uses Splat v2.0 which isn't compatible with netstandard2.0
What is the new behavior (if this is a feature change)?
Uses Splat v3.0 which is compatible with netstandard2.0
What might this PR break?
Folks who are using pre-release builds will be automatically upgraded to splat3.0 when they upgrade their binary dependancy if they are using Visual Studio for Windows and packageref.
referenced this pull request
Apr 24, 2018
The ReactiveUI targets need to also be bumped to netstandard20.
Red build after adjusting targets for UAP. Not sure what's going on here yet.
@ghuntley I get that, but you don't need a netcoreapp version for that. Put the logic from
You should only need a netcoreapp version if there's types you need there that aren't in netstandard. Workbooks, Blazor, et al, will happily use the netstandard version.
Effectively what I'm suggesting is that you don't need a "reference assembly." .NET Standard is a fully featured one with defaults and the platform-specific ones superceed when they're available.
left a comment