New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: what if we were licensed under MIT? #1602

Merged
merged 2 commits into from May 1, 2018

Conversation

Projects
None yet
4 participants
@ghuntley
Copy link
Member

ghuntley commented May 1, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fixes #1580

What is the current behavior? (You can also link to an open issue here)

I keep getting reports from folks who want to contribute but their employer has a restrictive list of pre-approved licenses and MSPL isn't on that list.

What is the new behavior (if this is a feature change)?

What if we enabled those to help us? Much easier than making them go through internal corporate bs.

What might this PR break?

Feelings (tm). This PR is under review by the .NET Foundation legal team. If no issues, then we merge!

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 1, 2018

Coverage Status

Coverage remained the same at 72.257% when pulling 5241686 on what-if-we-were-mit into 581b959 on develop.

@paulcbetts

This comment has been minimized.

Copy link
Member

paulcbetts commented May 1, 2018

+1 from me, since DNF owns the copyright we can actually do this, and I didn't have any Secret VeryGood Reason to MSPL this

@martijn00 martijn00 referenced this pull request May 1, 2018

Merged

housekeeping: use https #2837

@ghuntley

This comment has been minimized.

Copy link
Member

ghuntley commented May 1, 2018

I dedicate this PR to @glennawatson. Thanks for all your help mate.

@ghuntley ghuntley merged commit 2176d57 into develop May 1, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@ghuntley ghuntley deleted the what-if-we-were-mit branch May 1, 2018

@olevett

This comment has been minimized.

Copy link
Member

olevett commented May 1, 2018

:)

ghuntley added a commit that referenced this pull request May 1, 2018

feature: what if we were licensed under MIT? (#1602) (#1608)
I keep getting reports from folks who want to contribute but their employer has a restrictive list of pre-approved licenses and MSPL isn't on that list. What if we enabled those to help us? Much easier than making them go through internal corporate bs.

@ghuntley ghuntley added this to the 8.0.0 milestone May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment