housekeeping: Use StartsWith in the csproj files to make it easier to target new versions #1623
Conversation
|
Aww shucks @martijn00. I was totally going to steal this from mvx and you have done it for us. Thank-you. ❤️ |
|
You could even change the folder names just like Mvx to be without the version number. Say you switch from netstandard2.0 to 2.1, the code probably still works. It would also be possible to target 1.0 and 2.0 from 1 folder. I just didn't want to make this change too big. |
|
Good call - yes changing folder names would be too big of a change right now. EDIT: I've changed my mind - let's change the folder names. |
|
@olevett I've broken something - the API approval tests are tripping. Any chance you could lend me a fresh set of eyes? |
ghuntley
changed the title
|
#1640 needs to be merged before this. edit: It's been merged. |
|
Will take a look... |
|
👍 thanks Olly. This will need some additional eyeballs/changes as that big |
src/Directory.build.props
Outdated
| <PublishRepositoryUrl>true</PublishRepositoryUrl> | ||
| <RepositoryUrl>https://github.com/reactiveui/ReactiveUI</RepositoryUrl> | ||
| <RepositoryType>git</RepositoryType> | ||
| <Product>$(AssemblyName) ($(TargetFramework))</Product> |
There was a problem hiding this comment.
Just a thought, is this behaving here? There's another PR around it I think where AssemblyName is sometimes null?
There was a problem hiding this comment.
Let the other review do this, since it's fixing it properly.
|
Given we have some conflicts can we get those fixed then we can work on getting this one integrated across? |
src/Directory.build.props
Outdated
| <PublishRepositoryUrl>true</PublishRepositoryUrl> | ||
| <RepositoryUrl>https://github.com/reactiveui/ReactiveUI</RepositoryUrl> | ||
| <RepositoryType>git</RepositoryType> | ||
| <Product>$(AssemblyName) ($(TargetFramework))</Product> |
There was a problem hiding this comment.
Let the other review do this, since it's fixing it properly.
|
The other review in question is #1604 |
glennawatson
force-pushed
the
flex-csproj
branch
from
e9c2912 to
a8ac8b7
Compare
glennawatson
changed the title
|
Thanks @martijn00 - Our PR list is now empty, thanks for the contribution 👍 |
… target new versions (#1623)
4 participants
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Say you want to target MonoAndroid81 instead of the current MonoAndroid80, you need to change all properties in the csproj file.
What is the new behavior (if this is a feature change)?
It is now easier because the names should only contain the platform.
What might this PR break?
Nothing
Please check if the PR fulfills these requirements
Other information: