feat: Update ReactiveUI to use Reactive Extensions 4.0.0 as minimum #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennawatson
commented
Aug 2, 2018
| <ProjectReference Include="..\ReactiveUI\ReactiveUI.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition=" '$(TargetFramework)' == 'Xamarin.Mac20' "> |
There was a problem hiding this comment.
I had to reference netstandard to get the Xamarin.Mac20 to compile after updating. Bit weird.
|
You should not need a |
|
Would it not make it easier for consuming users to have a .NET Core 2.1? Or would the JIT just go based on their API? Also my understanding is also they done a ton of performance operations on .NET Core 2.1 so potentially users targetting the framework could take advantage. |
|
.NET Core 2.1 is just an API surface area. It's no different than releasing .NET 4.6 and 4.6.1 at the same time. No need to unless you're using API's not in the lower version. |
added 2 commits
August 2, 2018 18:15
…tiveUI into glennawatson-rx4
|
Removed that platform until we need it then. Thanks for the info. |
glennawatson
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixes #1672
This changes the min version for ReactiveUI to use Rx 4.0.0
We are getting a few reports from users where upgrading to Rx 4.0.0 fixes their issues.
Also adding .NET .Core 2.1 as a target. It was partially done in a previous PR but this adds it to the other projects.
What is the current behavior? (You can also link to an open issue here)
Use Rx 3.1.1
What is the new behavior (if this is a feature change)?
Use Rx 4.0.0 and also .NET Core 2.1 added to other projects.
What might this PR break?
Users using Rx 3.1.1. will have to upgrade their package reference in nuget.