New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Added Code Analyzers #1749

Merged
merged 41 commits into from Oct 10, 2018

Conversation

Projects
None yet
3 participants
@RLittlesII
Copy link
Contributor

RLittlesII commented Sep 17, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Resolves #1733

What is the current behavior? (You can also link to an open issue here)
The project doesn't have a set of analyzers

What is the new behavior (if this is a feature change)?
The project will have analyzers to keep the code to the project style guide.

What might this PR break?
The build might break.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

RLittlesII and others added some commits Aug 29, 2018

housekeeping: Added Code Analyzers
Added StyleCop config
Added additional style cop analyzers to .ruleset
Removing stylecop fluff
Deviating from CoreFx style guide
Added XML Document generation
Added Analyzer overrides
- Added CA1507 as Warning
- Added CA1000 as None
- Added SA1400 as Error
- Added RCS1018 as Error
- Added RCS1507 as Error
- Added RCS1163 as Info
- Added SA1116 as Error
- Added RCS1139 as Error
- Added SA1626 as None
- Added RCS1001 as Error
- Added SA1503 as Error
- Added SA1513 as Error
- Added SA1127 as Error
- Added SA1614 as Error

Fixed SA1629
Fixed SX1309
Fixed IDE0040
Fixed SA1500
Fixed SA1400
Fixed SX1101
Fixed CA1507
Fixed RCS1057
Fixed RCS1037
Fixed RCS1139
Fixed RCS1001
Fixed SA1503
Fixed SA1500
Fixed SA1513
Fixed SA1107
Fixed SA1127
Fixed SX1101
Fixed SA1208
Fixed SX1101
Fixed SA1500
Fixed SA1107
Fixed RCS1037
Fixed SA1313
Fixed SA1300
Fixed SA1507
Fixed SA1001
Fixed SA1009
Fixed SA1001
Fixed SA1024
Fixed SA1027
Fixed SA1000
Fixed SA1137
Disabled SA1633
Fixed SA1611
Fixed SA1210
Fixed SA1614
Fixed SA1615
Fixed SA1117
Fixed CS1572
Fixed SA1616
Fixed SA1618
Fixed SA1622
Fixed SA1600
Fixed SA1401
Fixed SA1516
Fixed SA1518
Fixed SA1121
Fixed SX1101
Fixed SA1614
Fixed SA1121
Fixed RCS1037
Fixed SA1508
Fixed SA1501
Fixed RCS1207
Fixed RCS1211
Fixed SA1005
Fixed SA1303
Fixed SA1505
Fixed SA1512
Fixed CA1507
Fixed RCS1129
Fixed SA1515
Fixed SA1502

Added reactiveui.tests.ruleset
Moved Interactions
Moved Command Bindings
Moved Property Bindings
Moved Reactive Object
Moved Reactive Bindings
Moved Routing
Moved Reactive Command
Moved Interfaces
Moved Legacy Interfaces
Moved Scheduler
Move Property Classes
Moved Mixins
Moved Comparers
Moved Suspension
Moved Event Managers

@RLittlesII RLittlesII requested review from reactiveui/android-team as code owners Sep 17, 2018

glennawatson and others added some commits Sep 17, 2018

Fix warnings
Update .editorconfig to match the new analyzers.

RLittlesII added some commits Sep 27, 2018

Show resolved Hide resolved .editorconfig

@RLittlesII RLittlesII force-pushed the analyzers branch from 0f0fb48 to c809a02 Oct 2, 2018

RLittlesII added some commits Oct 4, 2018

@RLittlesII RLittlesII force-pushed the analyzers branch 2 times, most recently from 5835b44 to 58c1a0e Oct 9, 2018

@RLittlesII RLittlesII force-pushed the analyzers branch from 58c1a0e to 4a371cc Oct 10, 2018

@RLittlesII RLittlesII changed the title [WIP] housekeeping: Added Code Analyzers housekeeping: Added Code Analyzers Oct 10, 2018

@glennawatson glennawatson merged commit 4a7b6c7 into master Oct 10, 2018

2 of 3 checks passed

License Compliance 23 issues found
Details
WIP ready for review
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the analyzers branch Oct 10, 2018

RLittlesII added a commit to RLittlesII/ReactiveUI that referenced this pull request Oct 10, 2018

housekeeping: Added Code Analyzers (reactiveui#1749)
Added StyleCop config
Added additional style cop analyzers to .ruleset
Removing stylecop fluff
Deviating from CoreFx style guide
Added XML Document generation
Added Analyzer overrides
- Added CA1507 as Warning
- Added CA1000 as None
- Added SA1400 as Error
- Added RCS1018 as Error
- Added RCS1507 as Error
- Added RCS1163 as Info
- Added SA1116 as Error
- Added RCS1139 as Error
- Added SA1626 as None
- Added RCS1001 as Error
- Added SA1503 as Error
- Added SA1513 as Error
- Added SA1127 as Error
- Added SA1614 as Error

Fixed SA1629
Fixed SX1309
Fixed IDE0040
Fixed SA1500
Fixed SA1400
Fixed SX1101
Fixed CA1507
Fixed RCS1057
Fixed RCS1037
Fixed RCS1139
Fixed RCS1001
Fixed SA1503
Fixed SA1500
Fixed SA1513
Fixed SA1107
Fixed SA1127
Fixed SX1101
Fixed SA1208
Fixed SX1101
Fixed SA1500
Fixed SA1107
Fixed RCS1037
Fixed SA1313
Fixed SA1300
Fixed SA1507
Fixed SA1001
Fixed SA1009
Fixed SA1001
Fixed SA1024
Fixed SA1027
Fixed SA1000
Fixed SA1137
Disabled SA1633
Fixed SA1611
Fixed SA1210
Fixed SA1614
Fixed SA1615
Fixed SA1117
Fixed CS1572
Fixed SA1616
Fixed SA1618
Fixed SA1622
Fixed SA1600
Fixed SA1401
Fixed SA1516
Fixed SA1518
Fixed SA1121
Fixed SX1101
Fixed SA1614
Fixed SA1121
Fixed RCS1037
Fixed SA1508
Fixed SA1501
Fixed RCS1207
Fixed RCS1211
Fixed SA1005
Fixed SA1303
Fixed SA1505
Fixed SA1512
Fixed CA1507
Fixed RCS1129
Fixed SA1515
Fixed SA1502

Added reactiveui.tests.ruleset
Moved Interactions
Moved Command Bindings
Moved Property Bindings
Moved Reactive Object
Moved Reactive Bindings
Moved Routing
Moved Reactive Command
Moved Interfaces
Moved Legacy Interfaces
Moved Scheduler
Move Property Classes
Moved Mixins
Moved Comparers
Moved Suspension
Moved Event Managers

Part of the work with commenting up the classes.

Further work on commenting. Moved some legacy classes into the Legacy
folder.

Further documentation.

Fix the analyzer reference.

Further documenting the classes.

Further work on commenting the classes.

Further updates to the comments.

Further comment work

Starting to fix the warnings on the branch.

Fix warnings
Update .editorconfig to match the new analyzers.

.EditorConfig now matches the new analyzers
More warning updates.

Added comments to ReactiveUI.XamForms

Futher work on eliminating warnings.

Further work on eliminating warnings.

Further work on eliminating warnings.

Eliminating warnings

Further fixing of warnings.

Moved non-.net standard compatible overloads.

Further warning updates.

Added comments to ReactiveUI.Fody

Added Android comments

added more android comments

Added additional comments

Added more comments

standardized RoutingState comments

cleared sa1600 errors

Event Builder clean up

Event builder comments

Added SA1600 to mustache

Added xml comments to mustache

Modified API approved text

@glennawatson glennawatson referenced this pull request Oct 12, 2018

Closed

RFC: Turn on Analyzers #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment