New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to register views for externally loaded modules #1847

Merged
merged 3 commits into from Dec 1, 2018

Conversation

Projects
None yet
2 participants
@glennawatson
Copy link
Contributor

glennawatson commented Dec 1, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fixes #1841

If a assembly is loaded using the LoadFrom() methods it will fail to work with Type.LoadFrom().

What is the current behavior? (You can also link to an open issue here)
Uses Type.GetType() without a custom assembly lookup.

What is the new behavior (if this is a feature change)?
Based on https://stackoverflow.com/questions/11430654/is-it-possible-to-use-type-gettype-with-a-dynamically-loaded-assembly

Now use a lookup for the assembly.

What might this PR break?
Potentially some platforms. Will require proper testing.

@glennawatson glennawatson requested a review from reactiveui/core-team as a code owner Dec 1, 2018

@glennawatson glennawatson merged commit 39abffe into master Dec 1, 2018

1 check passed

license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-fix-external-assembly-lookup branch Dec 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment