New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: remove warnings from code base #1851

Merged
merged 2 commits into from Dec 4, 2018

Conversation

Projects
None yet
2 participants
@glennawatson
Copy link
Contributor

glennawatson commented Dec 3, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Housekeeping

What is the current behavior? (You can also link to an open issue here)

Lots of warnings

What is the new behavior (if this is a feature change)?

Fix a lot of the random warnings mostly in the test project.

@glennawatson glennawatson requested review from reactiveui/core-team as code owners Dec 3, 2018

@olevett
Copy link
Member

olevett left a comment

👍

Glenn Watson

@glennawatson glennawatson merged commit 5130ff9 into master Dec 4, 2018

1 check passed

license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-cleanup-warnings branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment