New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation explaining how to use ReactiveUserControl in XAML #1855

Merged
merged 2 commits into from Dec 11, 2018

Conversation

Projects
None yet
2 participants
@jorisvergeer
Copy link
Contributor

jorisvergeer commented Dec 10, 2018

Add documentation explaining how to use ReactiveUserControl in XAML in UWP projects and the WPF designer window.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update

What is the current behavior? (You can also link to an open issue here)
#1853

Add documentation explaining how to use ReactiveUserControl in XAML i…
…n UWP projects and the WPF designer window

@jorisvergeer jorisvergeer requested review from reactiveui/uwp-team as code owners Dec 10, 2018

@glennawatson
Copy link
Contributor

glennawatson left a comment

Thanks for doing this.

Show resolved Hide resolved src/ReactiveUI/Platforms/windows-common/ReactiveUserControl.cs Outdated
@@ -36,6 +36,33 @@ namespace ReactiveUI
/// ]]>
/// </code>
/// </para>
/// <para>
/// Note that UWP projects do not support the <c>TypeArguments</c> attribute. The XAML designer window in WPF projects also do not
/// support generic types. To use <see cref="ReactiveUserControl{TViewModel}"/> in XAML documents you need to create a base class

This comment has been minimized.

@glennawatson

glennawatson Dec 11, 2018

Contributor

You don't have to do it this way. The xaml designer is do fragile I gave up on it years ago. So might be worth saying more like "to use the base class"

This comment has been minimized.

@jorisvergeer

jorisvergeer Dec 11, 2018

Contributor

It doesn't compile in an UWP (it does in WPF) project when you just use ReactiveUserControl. The xaml designer is an extra for me.

@glennawatson
Copy link
Contributor

glennawatson left a comment

Makes sense.

@glennawatson glennawatson merged commit 3a05159 into reactiveui:master Dec 11, 2018

1 check passed

license/cla All CLA requirements met.
Details

@jorisvergeer jorisvergeer deleted the jorisvergeer:documentation-fixes branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment