New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: cleanup opencover testing and test projects #1867

Merged
merged 3 commits into from Dec 27, 2018

Conversation

Projects
None yet
2 participants
@glennawatson
Copy link
Contributor

glennawatson commented Dec 27, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

housekeeping

What is the new behavior (if this is a feature change)?

  1. Update the test projects to use the Directory.Build.Props
  2. Now the main folder has its own ruleset files, integration tests and other user facing items will get their own style sheet in the future.
  3. Cleanup the test projects to use dependencies from the Directory.Build.Prop's files.

@glennawatson glennawatson requested review from reactiveui/core-team as code owners Dec 27, 2018

.ExcludeByFile("*ApprovalTests*"));
OpenCover(tool => RunTests(tool, "ReactiveUI.Tests"), testCoverageOutputFile, openCoverSettings);
OpenCover(tool => RunTests(tool, "ReactiveUI.Fody.Tests"), testCoverageOutputFile, openCoverSettings);
// TODO: seems the leak tests never worked as part of the CI, fix. For the moment just make sure it compiles.

This comment has been minimized.

@olevett

olevett Dec 27, 2018

Member

Is it worth raising an issue for this bit?

This comment has been minimized.

@glennawatson

glennawatson Dec 27, 2018

Contributor

Probably. Will do it in a sec

</ItemGroup>

<ItemGroup>
<PackageReference Include="xunit" Version="2.4.1" />

This comment has been minimized.

@olevett

@glennawatson glennawatson merged commit 8c28dd1 into master Dec 27, 2018

1 check passed

license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-update-covers branch Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment