New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: remove code analyzers from base directory. (#1870) #1870

Merged
merged 1 commit into from Dec 27, 2018

Conversation

Projects
None yet
2 participants
@glennawatson
Copy link
Contributor

glennawatson commented Dec 27, 2018

No description provided.

@glennawatson glennawatson requested a review from reactiveui/core-team as a code owner Dec 27, 2018

@RLittlesII
Copy link
Contributor

RLittlesII left a comment

Are you moving the directory properties down a level?

@glennawatson

This comment has been minimized.

Copy link
Contributor

glennawatson commented Dec 27, 2018

Basically, the theory being the /src folders will have their own settings, and integration tests/samples will have their own. Eg the samples have some by other members eg @giusepe who may have different coding standards.

@RLittlesII

This comment has been minimized.

Copy link
Contributor

RLittlesII commented Dec 27, 2018

Shouldn't you remove the CodeAnalysisRuleSet xml tag earlier in this file?

@RLittlesII
Copy link
Contributor

RLittlesII left a comment

Based on slack conversation. Glenn explained what I was missing. Approved.

@RLittlesII RLittlesII changed the title housekeeping: remove code analyzers from base directory. housekeeping: remove code analyzers from base directory. (#1870) Dec 27, 2018

@RLittlesII RLittlesII merged commit c9fd02a into master Dec 27, 2018

1 check passed

license/cla All CLA requirements met.

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-patch-1 branch Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment