New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Fix the majority of warnings in the project. (#1872) #1872

Merged
merged 1 commit into from Dec 28, 2018

Conversation

Projects
None yet
4 participants
@glennawatson
Copy link
Contributor

glennawatson commented Dec 28, 2018

  • Majority of warnings are now eliminated.
  • Analyzer warnings are now errors
  • Created a suppression file for the API Generator that gets injected from nuget. this will have to change if we upgrade api generator but easy enough.

@glennawatson glennawatson requested review from reactiveui/android-team as code owners Dec 28, 2018

@gpriaulx
Copy link
Contributor

gpriaulx left a comment

Looks like a lot of effort went into this clean up!

@worldbeater
Copy link
Member

worldbeater left a comment

💖

@RLittlesII
Copy link
Contributor

RLittlesII left a comment

LGTM!

@RLittlesII RLittlesII changed the title housekeeping: Fix the majority of warnings in the project. housekeeping: Fix the majority of warnings in the project. (#1872) Dec 28, 2018

@RLittlesII RLittlesII merged commit 5cab37c into master Dec 28, 2018

1 check passed

license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-fix-all-warnings branch Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment