New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WhenNavigatingFromObservable completes when NavigateAndReset is invoked (#1875) #1875

Merged
merged 2 commits into from Dec 29, 2018

Conversation

Projects
None yet
2 participants
@SpiegelSoft
Copy link
Contributor

SpiegelSoft commented Dec 29, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug Fix

What is the current behavior? (You can also link to an open issue here)
#1874

What is the new behavior (if this is a feature change)?
WhenNavigatingFromObservable completes when NavigateAndReset is invoked

What might this PR break?
Navigation operations

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
This is crucial for my project, as the WhenNavigatingFromObservable() feature is critical for cleanup.

@SpiegelSoft SpiegelSoft requested a review from reactiveui/core-team as a code owner Dec 29, 2018

@RLittlesII
Copy link
Contributor

RLittlesII left a comment

LGTM

@RLittlesII RLittlesII changed the title WhenNavigatingFromObservable completes when NavigateAndReset is invoked fix: WhenNavigatingFromObservable completes when NavigateAndReset is invoked (#1875) Dec 29, 2018

@RLittlesII RLittlesII merged commit b020795 into reactiveui:master Dec 29, 2018

1 check passed

license/cla All CLA requirements met.
Details
@RLittlesII

This comment has been minimized.

Copy link
Contributor

RLittlesII commented Dec 29, 2018

@SpiegelSoft Thank You for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment