New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Use NuGet PackageLicenseLiteral, update fody. #1876

Merged
merged 1 commit into from Dec 30, 2018

Conversation

Projects
None yet
1 participant
@glennawatson
Copy link
Contributor

glennawatson commented Dec 30, 2018

  • Nuget now wants either PackageLicenseLiteral or PackageLicenseFile. Using the literal for MIT
  • Update to Fody 3.3.5 which removes issues for PackageLicenseLiteral.
housekeeping: Use NuGet PackageLicenseLiteral, update fody.
- Nuget now wants either PackageLicenseLiteral or PackageLicenseFile. Using the literal for MIT
- Update to Fody 3.3.5 which removes issues for PackageLicenseLiteral.

@glennawatson glennawatson requested review from reactiveui/core-team as code owners Dec 30, 2018

@@ -1,8 +1,6 @@
<Project Sdk="MSBuild.Sdk.Extras">
<PropertyGroup>
<TargetFrameworks>netstandard2.0;net461;uap10.0.16299;Xamarin.iOS10;Xamarin.Mac20;Xamarin.TVOS10;MonoAndroid81;netcoreapp2.0</TargetFrameworks>
<AssemblyName>ReactiveUI.Fody.Helpers</AssemblyName>

This comment has been minimized.

@glennawatson

glennawatson Dec 30, 2018

Contributor

The default of both AssemblyName/RootNamespace is the name of the .csproj, so redundant.

@glennawatson glennawatson merged commit c6b0587 into master Dec 30, 2018

1 check passed

license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-update-package branch Dec 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment