New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Moving package signing into Cake script #1886

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@RLittlesII
Copy link
Contributor

RLittlesII commented Jan 4, 2019

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Moves the code signing of ReactiveUI nuget packages into the Cake script

What is the current behavior? (You can also link to an open issue here)
Currently we call out to a powershell script from the Cake script.

What is the new behavior (if this is a feature change)?
The Cake script will call the global SignClient dotnet tool directly from Cake.

What might this PR break?
The code signing process.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@RLittlesII RLittlesII requested a review from reactiveui/devops-team as a code owner Jan 4, 2019

@RLittlesII RLittlesII force-pushed the RLittlesII:sign-client branch from 3ec2bce to 2e9267f Jan 4, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #1886 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1886   +/-   ##
======================================
  Coverage    66.4%   66.4%           
======================================
  Files         110     110           
  Lines        4387    4387           
  Branches      579     579           
======================================
  Hits         2913    2913           
  Misses       1305    1305           
  Partials      169     169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc8fa8...8cae994. Read the comment docs.

Show resolved Hide resolved build.cake Outdated
Show resolved Hide resolved build.ps1

@RLittlesII RLittlesII force-pushed the RLittlesII:sign-client branch from 28687e8 to d8dd522 Jan 4, 2019

housekeeping: Moving package signing into Cake script
- Fixed packagesArtifactFirectory
- Explicitly typed nupkg to FilePath
- Removed SignPackages.ps1

@RLittlesII RLittlesII force-pushed the RLittlesII:sign-client branch from d8dd522 to 8cae994 Jan 4, 2019

@RLittlesII RLittlesII changed the title [WIP] housekeeping: Moving package signing into Cake script housekeeping: Moving package signing into Cake script Jan 4, 2019

@RLittlesII

This comment has been minimized.

Copy link
Contributor

RLittlesII commented Jan 4, 2019

@glennawatson I think this is read for final review.

@RLittlesII RLittlesII merged commit f9a9308 into reactiveui:master Jan 4, 2019

4 checks passed

ReactiveUI Tests #9.7.4+52fb0ae989 succeeded
Details
codecov/patch Coverage not affected when comparing 8dc8fa8...8cae994
Details
codecov/project 66.4% remains the same compared to 8dc8fa8
Details
license/cla All CLA requirements met.
Details

@RLittlesII RLittlesII deleted the RLittlesII:sign-client branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment