New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Correct ReactiveUserControl xml docs #1888

merged 1 commit into from Jan 5, 2019


None yet
2 participants
Copy link

worldbeater commented Jan 5, 2019

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR fixes two documentation issues, see reactiveui/website#122 and reactiveui/website#127

What is the current behavior? (You can also link to an open issue here)

ReactiveUserControl<TViewModel> xml-doc describing it's usage is wrong, there are missing XAML directives xmlns and xmlns:x, also x:Class syntax is wrong, if someone would copy-paste that snippet, their project won't compile.

What is the new behavior (if this is a feature change)?

Missing directives are added, alongside with xmlns:mc and xmlns:d as they are also common.

What might this PR break?


@worldbeater worldbeater requested review from reactiveui/uwp-team as code owners Jan 5, 2019

@worldbeater worldbeater requested a review from reactiveui/learning-team Jan 5, 2019


This comment has been minimized.

Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #1888 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1888   +/-   ##
  Coverage    66.4%   66.4%           
  Files         110     110           
  Lines        4387    4387           
  Branches      579     579           
  Hits         2913    2913           
  Misses       1305    1305           
  Partials      169     169
Impacted Files Coverage Δ
...UI/Platforms/windows-common/ReactiveUserControl.cs 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691a8e3...74c9d4d. Read the comment docs.

@worldbeater worldbeater changed the title Correct ReactiveUserControl xml docs housekeeping: Correct ReactiveUserControl xml docs Jan 5, 2019

@glennawatson glennawatson merged commit 0a84cb7 into master Jan 5, 2019

4 checks passed

ReactiveUI Tests #9.7.7+47e52ab7e1 succeeded
codecov/patch Coverage not affected when comparing 691a8e3...74c9d4d
codecov/project 66.4% remains the same compared to 691a8e3
license/cla All CLA requirements met.

@delete-merged-branch delete-merged-branch bot deleted the correct-rxcontrol-xml-docs branch Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment