New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Integration tests view model unit tests #1891

Merged
merged 22 commits into from Jan 6, 2019

Conversation

Projects
None yet
6 participants
@cabauman
Copy link
Contributor

cabauman commented Jan 6, 2019

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
closes #1716

What is the current behavior? (You can also link to an open issue here)
No unit tests

What is the new behavior (if this is a feature change)?
Passing unit tests for view models contained in the shared integration test project

What might this PR break?
Nothing

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
All tests now pass consistently.

I committed a DependencyResolver test fix but then decided to delete it because it tests core ReactiveUI functionality rather than anything specific to the integration test project. I think something like that would go better in the ReactiveUI.Tests project (but I think it's already covered).

giusepe and others added some commits Aug 21, 2018

WIP: Updated the ViewModel Unit Tests
2 Tests are still broken
Functioning set of tests
- DepedencyResolverMixinTests still has a failing test
Delete DependencyResolver test
- It tests core ReactiveUI functionality rather than anything specific to the integration test project.

@cabauman cabauman requested a review from reactiveui/core-team as a code owner Jan 6, 2019

<OutputType>WinExe</OutputType>
<RootNamespace>IntegrationTests.WinForms</RootNamespace>

This comment has been minimized.

@glennawatson

glennawatson Jan 6, 2019

Contributor

Change back.

[assembly: AssemblyDescription("")]
[assembly: AssemblyConfiguration("")]
[assembly: AssemblyCompany("")]
[assembly: AssemblyProduct("IntegrationTests.WinForms")]

This comment has been minimized.

@glennawatson

glennawatson Jan 6, 2019

Contributor

change back

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #1891 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1891   +/-   ##
======================================
  Coverage    66.4%   66.4%           
======================================
  Files         110     110           
  Lines        4387    4387           
  Branches      579     579           
======================================
  Hits         2913    2913           
  Misses       1305    1305           
  Partials      169     169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1288a10...36c4fb9. Read the comment docs.

@glennawatson glennawatson changed the title Integration tests view model unit tests housekeeping: Integration tests view model unit tests Jan 6, 2019

@glennawatson glennawatson changed the title housekeeping: Integration tests view model unit tests fix: Integration tests view model unit tests Jan 6, 2019

@glennawatson glennawatson force-pushed the IntegrationTestsViewModelUnitTests branch from c6c9c12 to 5d02088 Jan 6, 2019

@glennawatson glennawatson merged commit be798fe into master Jan 6, 2019

4 checks passed

ReactiveUI Tests #9.7.23+1d10669872 succeeded
Details
codecov/patch Coverage not affected when comparing 1288a10...36c4fb9
Details
codecov/project 66.4% remains the same compared to 1288a10
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the IntegrationTestsViewModelUnitTests branch Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment