New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: fix signing to work/use nbgv from cake. #1895

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@glennawatson
Copy link
Contributor

glennawatson commented Jan 7, 2019

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

housekeeping

What is the current behavior? (You can also link to an open issue here)

The signing does not work.
The nerdbank git versioning happens inside the azure script.

What is the new behavior (if this is a feature change)?

Fixes the two things above.

@glennawatson glennawatson requested review from reactiveui/core-team as code owners Jan 7, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #1895 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1895   +/-   ##
======================================
  Coverage    66.4%   66.4%           
======================================
  Files         110     110           
  Lines        4387    4387           
  Branches      579     579           
======================================
  Hits         2913    2913           
  Misses       1305    1305           
  Partials      169     169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00eff40...211e3d9. Read the comment docs.

@glennawatson glennawatson merged commit 741577c into master Jan 7, 2019

4 checks passed

ReactiveUI Tests #9.7.15+b90a5a60ed succeeded
Details
codecov/patch Coverage not affected when comparing 00eff40...211e3d9
Details
codecov/project 66.4% remains the same compared to 00eff40
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-build-signing branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment