New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: .NET Core App 2.0 tests & Tests Cleanups #1926

Merged
merged 10 commits into from Jan 24, 2019

Conversation

Projects
None yet
2 participants
@glennawatson
Copy link
Contributor

glennawatson commented Jan 22, 2019

  • Now compiling for .net core app 2.0, .net 4.6.1, uwp (not yet being run --next pass)
  • Turned on most of the analyzers for the test project. Cleaned up approriately
  • Updated the cake build script to do coverage tests on platforms where they are supported
  • Updated open cover version.
  • Approval tests now include the framework version.
housekeeping: .NET Core App 2.0 tests & Tests Cleanups
* Now compiling for .net core app 2.0, .net 4.6.1, uwp (not yet being run --next pass)
* Turned on most of the analyzers for the test project. Cleaned up approriately
* Updated the cake build script to do coverage tests on platforms where they are supported
* Updated open cover version.
* Approval tests now include the framework version.

@glennawatson glennawatson requested review from reactiveui/core-team as code owners Jan 22, 2019

glennawatson added some commits Jan 22, 2019

Fix compilation issues.
Fix compilation issues.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #1926 into master will decrease coverage by 2.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1926      +/-   ##
=========================================
- Coverage   66.64%   64.4%   -2.24%     
=========================================
  Files         110      99      -11     
  Lines        4374    3574     -800     
  Branches      578     899     +321     
=========================================
- Hits         2915    2302     -613     
+ Misses       1289    1140     -149     
+ Partials      170     132      -38
Impacted Files Coverage Δ
.../Bindings/Property/PropertyBinderImplementation.cs 85.09% <0%> (-2.89%) ⬇️
.../Bindings/Command/CreatesCommandBindingViaEvent.cs 89.74% <0%> (-2.57%) ⬇️
src/ReactiveUI/Expression/Reflection.cs 60.71% <0%> (-1.43%) ⬇️
src/ReactiveUI/RxApp.cs 66.66% <0%> (-1.34%) ⬇️
src/ReactiveUI/Legacy/ReactiveList.cs
src/ReactiveUI/Legacy/ReactiveCollectionMixins.cs
src/ReactiveUI.Winforms/ReactiveBindingList.cs
src/ReactiveUI/Legacy/MoveInfo.cs
.../Legacy/ReactiveDerivedCollectionFromObservable.cs
src/ReactiveUI/Legacy/ObservableCollectionMixin.cs
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17d5bfa...06f2188. Read the comment docs.

@glennawatson glennawatson requested a review from reactiveui/winforms-team as a code owner Jan 24, 2019

@RLittlesII
Copy link
Contributor

RLittlesII left a comment

My only comment/question is use of xaml to denote uwp and wpf frameworks? Should we change it to windows, seeing as how platforms like Xamarin also uses xaml?

@glennawatson glennawatson merged commit 5989379 into master Jan 24, 2019

3 of 4 checks passed

codecov/project 64.4% (-2.24%) compared to 17d5bfa
Details
ReactiveUI Tests #9.8.29+0c0e9b4827 succeeded
Details
codecov/patch Coverage not affected when comparing 17d5bfa...06f2188
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-fix-combobox-empty branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment