New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Make ReactiveUI compile on VisualStudio for Mac #1932

Merged
merged 10 commits into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@glennawatson
Copy link
Contributor

glennawatson commented Jan 26, 2019

  • Modified the Events projects to handle compiling on mac
  • Android events now look for desired version on both windows/mac
  • Modified the azure to run tests/ci on both windows/mac
  • If not compiling on windows exclude uwp/net461
  • Fix the build.sh to use the same as what the cake build team uses, and uses a global tool
  • Turn off sourcelink for mac building temporarily. We don't use it for generating the NuGet packages anyway
  • Modified Fody to not rely on TargetFramework for where to copy files from.
  • Also fixed Fody compilation when it copies from the helper project, to wait until the sub-projects have a chance to compile first.

@glennawatson glennawatson requested review from reactiveui/core-team as code owners Jan 26, 2019

@glennawatson glennawatson force-pushed the vs4mac-compilation branch from 47d5261 to ce23dce Jan 28, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #1932 into master will increase coverage by 2.9%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1932     +/-   ##
=========================================
+ Coverage   64.49%   67.39%   +2.9%     
=========================================
  Files          99       99             
  Lines        3585     4815   +1230     
  Branches      903      465    -438     
=========================================
+ Hits         2312     3245    +933     
- Misses       1138     1443    +305     
+ Partials      135      127      -8
Impacted Files Coverage Δ
...rc/ReactiveUI/Activation/CanActivateViewFetcher.cs 33.33% <0%> (-16.67%) ⬇️
src/ReactiveUI.Winforms/Registrations.cs 54.54% <0%> (-7.96%) ⬇️
...ctiveUI/Bindings/Property/PropertyBindingMixins.cs 80% <0%> (-7.5%) ⬇️
...ReactiveUI/Scheduler/WaitForDispatcherScheduler.cs 75.86% <0%> (-6.5%) ⬇️
...ctiveUI/ReactiveCommand/CombinedReactiveCommand.cs 70.14% <0%> (-6.22%) ⬇️
src/ReactiveUI/Mixins/AutoPersistHelper.cs 91.39% <0%> (-5.44%) ⬇️
...ommand/CreatesCommandBindingViaCommandParameter.cs 91.17% <0%> (-5.12%) ⬇️
...activeUI/Bindings/Command/CreatesCommandBinding.cs 77.35% <0%> (-4.46%) ⬇️
...orms/windows-common/AutoDataTemplateBindingHook.cs 79.54% <0%> (-3.79%) ⬇️
...veUI/Interactions/UnhandledInteractionException.cs 37.03% <0%> (-2.97%) ⬇️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8c07e9...ca96b47. Read the comment docs.

@glennawatson glennawatson force-pushed the vs4mac-compilation branch from 4178def to 9563ab1 Jan 28, 2019

@glennawatson glennawatson force-pushed the vs4mac-compilation branch from 9563ab1 to f3b9218 Jan 28, 2019

glennawatson added some commits Jan 30, 2019

@glennawatson glennawatson changed the title (wip) housekeeping: Make ReactiveUI compile on VisualStudio for Mac housekeeping: Make ReactiveUI compile on VisualStudio for Mac Jan 31, 2019

@RLittlesII RLittlesII merged commit 26ac371 into master Jan 31, 2019

4 checks passed

ReactiveUI Tests #9.9.6+045c3bc5c3 succeeded
Details
codecov/patch Coverage not affected when comparing c8c07e9...ca96b47
Details
codecov/project 67.39% (+2.9%) compared to c8c07e9
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the vs4mac-compilation branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment