Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added support for binding events that use RoutedEventArgs #194

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Had to add and extra flavour of BindCommand in the interface to keep the parameter mapping nice and simple. Hope this is ok with the way you do things.

Owner

paulcbetts commented Feb 28, 2013

I don't understand why the original code doesn't work - doesn't RoutedEventArgs derive from EventArgs?

No it doesn’t.
Well not on Win RT at least. I didn’t look at other platforms.

From: Paul Betts [mailto:notifications@github.com]
Sent: Friday, 1 March 2013 5:15 AM
To: reactiveui/ReactiveUI
Cc: Bryden Oliver
Subject: Re: [ReactiveUI] Added support for binding events that use RoutedEventArgs (#194)

I don't understand why the original code doesn't work - doesn't RoutedEventArgs derive from EventArgs?


Reply to this email directly or view it on GitHubhttps://github.com/reactiveui/ReactiveUI/pull/194#issuecomment-14247916.

Owner

paulcbetts commented Mar 11, 2013

Hm, I'll look into this, though the "2" Moniker feels a little Weird™

I wasn’t entirely happy with it either, but I couldn’t convince the compiler that the 2 method signatures were different if I overloaded the method.
Maybe BindRoutedEvent given it’s not an exposed method, it doesn’t matter too much though.

From: Paul Betts [mailto:notifications@github.com]
Sent: Monday, 11 March 2013 5:55 PM
To: reactiveui/ReactiveUI
Cc: Bryden Oliver
Subject: Re: [ReactiveUI] Added support for binding events that use RoutedEventArgs (#194)

Hm, I'll look into this, though the "2" Moniker feels a little Weird™


Reply to this email directly or view it on GitHubhttps://github.com/reactiveui/ReactiveUI/pull/194#issuecomment-14699740.

@jlaanstra jlaanstra added a commit that referenced this pull request Apr 8, 2013

@jlaanstra jlaanstra On WinRT there is no requirement for EventArgs to be of type EventArg…
…s. Drop the requirement for WinRT just like Rx does.


Fixes #194
b87b5a9

@jlaanstra jlaanstra closed this in d19c8c4 Apr 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment