New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(housekeeping) Upgraded Xamarin.Forms to v3.4 #1942

Merged
merged 3 commits into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@RLittlesII
Copy link
Contributor

RLittlesII commented Feb 8, 2019

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Upgrade Xamarin.Forms to version 3.4

What is the current behavior? (You can also link to an open issue here)

Xamarin.Forms targets version 3.3

What is the new behavior (if this is a feature change)?

Xamarin.Forms targets version 3.4

What might this PR break?

Xamarin.Forms based controls

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@RLittlesII RLittlesII requested review from reactiveui/core-team as code owners Feb 8, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #1942 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1942   +/-   ##
=======================================
  Coverage   67.39%   67.39%           
=======================================
  Files          99       99           
  Lines        4815     4815           
  Branches      465      465           
=======================================
  Hits         3245     3245           
  Misses       1443     1443           
  Partials      127      127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ceddd1...1dbcd4c. Read the comment docs.

@glennawatson
Copy link
Contributor

glennawatson left a comment

You need to change the event builder also.

Changed EventBuilder to use Xamarin.Forms 3.4.*
- Cleaned up modifier sorts
@RLittlesII

This comment has been minimized.

Copy link
Contributor Author

RLittlesII commented Feb 8, 2019

I attempted to change the Xamarin version in the Platform to 3.4.*, seems that depends on a full semantic version to resolve correctly.

@glennawatson glennawatson merged commit 9f4392b into reactiveui:master Feb 8, 2019

4 checks passed

ReactiveUI Tests #9.9.10+37189b9b18 succeeded
Details
codecov/patch Coverage not affected when comparing 6ceddd1...1dbcd4c
Details
codecov/project 67.39% remains the same compared to 6ceddd1
Details
license/cla All CLA requirements met.
Details

@RLittlesII RLittlesII deleted the RLittlesII:xamarin branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment