Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Make ReactiveUI use the new ReactiveUI.Cake.Recipe #1953

Merged
merged 2 commits into from Feb 16, 2019

Conversation

Projects
None yet
2 participants
@glennawatson
Copy link
Contributor

glennawatson commented Feb 16, 2019

To keep the builds consistent between all projects, we are now using a common cake recipe.

@glennawatson glennawatson requested review from reactiveui/core-team as code owners Feb 16, 2019

Show resolved Hide resolved azure-pipelines.yml
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 16, 2019

Codecov Report

Merging #1953 into master will decrease coverage by 8.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1953     +/-   ##
=========================================
- Coverage   67.41%   59.01%   -8.4%     
=========================================
  Files          99      117     +18     
  Lines        4815     4780     -35     
  Branches      465      678    +213     
=========================================
- Hits         3246     2821    -425     
- Misses       1443     1786    +343     
- Partials      126      173     +47
Impacted Files Coverage Δ
...activeUI/Platforms/net461/PlatformRegistrations.cs 28.57% <0%> (-71.43%) ⬇️
...c/ReactiveUI/Bindings/Converter/StringConverter.cs 33.33% <0%> (-9.53%) ⬇️
src/ReactiveUI/Expression/ExpressionRewriter.cs 40% <0%> (-7.92%) ⬇️
src/ReactiveUI/Mixins/ExpressionMixins.cs 81.08% <0%> (-5.96%) ⬇️
src/ReactiveUI/VariadicTemplates.cs 36.65% <0%> (-4.66%) ⬇️
.../ObservableForProperty/IROObservableForProperty.cs 50% <0%> (-4.17%) ⬇️
...tiveUI/Bindings/Converter/EqualityTypeConverter.cs 84.44% <0%> (-3.06%) ⬇️
src/ReactiveUI/Expression/Reflection.cs 62.85% <0%> (-2.63%) ⬇️
...rc/ReactiveUI.Winforms/ActivationForViewFetcher.cs 59.25% <0%> (-2.45%) ⬇️
src/ReactiveUI/Activation/ViewModelActivator.cs 82.6% <0%> (-2.24%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd700ac...299d318. Read the comment docs.

@glennawatson

This comment has been minimized.

Copy link
Contributor Author

glennawatson commented Feb 16, 2019

the change in codecov is due to the fact we use a Release build without optimisation now. (use Release so we don't have #debug stuff happening but no optimisations so we get full code coverage)

@glennawatson glennawatson merged commit 5a22c41 into master Feb 16, 2019

2 of 3 checks passed

codecov/project 59.01% (-8.4%) compared to cd700ac
Details
codecov/patch Coverage not affected when comparing cd700ac...299d318
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-cake-recipe branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.