Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Fix typo in the [GitHub issues] url #1958

Merged
merged 1 commit into from Feb 21, 2019

Conversation

Projects
None yet
3 participants
@martingemme
Copy link
Contributor

martingemme commented Feb 21, 2019

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
[Very] Small change to README.md

What is the current behavior? (You can also link to an open issue here)
Without the http protocol (http:// or https://), Markdown translates github.com/reactiveui/ReactiveUI/issues into https://github.com/reactiveui/ReactiveUI/blob/master/github.com/reactiveui/ReactiveUI/issues, which is not a page that exists!

What is the new behavior (if this is a feature change)?
The link works ⚡️

What might this PR break?
Nothing

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
It works (without http/https) for Passing on knowledge and teaching the next generation of developers, unsure why to be frank.

Fix typo in the [GitHub issues] url
Without the http protocol (`http://` or `https://`), Markdown translates `github.com/reactiveui/ReactiveUI/issues` into `https://github.com/reactiveui/ReactiveUI/blob/master/github.com/reactiveui/ReactiveUI/issues`, which is not a page that exists!

@martingemme martingemme requested a review from reactiveui/learning-team as a code owner Feb 21, 2019

@worldbeater
Copy link
Member

worldbeater left a comment

LGTM. Thank you for the contribution! 💖

@worldbeater worldbeater changed the title Fix typo in the [GitHub issues] url housekeeping: Fix typo in the [GitHub issues] url Feb 21, 2019

@glennawatson glennawatson merged commit 9838ca6 into reactiveui:master Feb 21, 2019

1 check passed

license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.