Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(housekeeping) Upgraded Xamarin.Forms to v3.5 #1965

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@RLittlesII
Copy link
Member

commented Mar 7, 2019

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Updates Xamarin.Forms to version 3.5.x

What is the current behavior? (You can also link to an open issue here)

ReactiveUI targets Xamarin.Forms version 3.4.x

What is the new behavior (if this is a feature change)?

ReactiveUI targets Xamarin.Forms version 3.5.x

What might this PR break?

Events?

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@RLittlesII RLittlesII requested review from reactiveui/core-team as code owners Mar 7, 2019

@glennawatson

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

How about in the event generator?

@RLittlesII

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

When I built locally the Tizen event generator failed. But that is semi normal behavior on my windows box. So I am letting the build server dictate if there is an issue generating the events.

I remember we had the question of if Xamarin.Forms 3.5 broke events.

@codecov

This comment has been minimized.

Copy link

commented Mar 7, 2019

Codecov Report

Merging #1965 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1965   +/-   ##
=======================================
  Coverage   58.39%   58.39%           
=======================================
  Files         120      120           
  Lines        4805     4805           
  Branches      691      691           
=======================================
  Hits         2806     2806           
  Misses       1822     1822           
  Partials      177      177

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd6dfd3...5c88a41. Read the comment docs.

@RLittlesII RLittlesII force-pushed the xamarin branch from d05f4b4 to a0dbcca Mar 7, 2019

(housekeeping) Upgraded Xamarin.Forms to v3.5
Changed EventBuilder Xamarin Platform to target 3.5.0.129452

@RLittlesII RLittlesII force-pushed the xamarin branch from a0dbcca to 5c88a41 Mar 7, 2019

@RLittlesII RLittlesII merged commit 4662017 into master Mar 7, 2019

3 checks passed

codecov/patch Coverage not affected when comparing fd6dfd3...5c88a41
Details
codecov/project 58.39% remains the same compared to fd6dfd3
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the xamarin branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.