Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ReactiveUI.Validation section in README. #1968

Merged
merged 3 commits into from Mar 13, 2019

Conversation

Projects
None yet
4 participants
@alexmartinezm
Copy link
Contributor

alexmartinezm commented Mar 12, 2019

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@alexmartinezm alexmartinezm requested a review from reactiveui/learning-team as a code owner Mar 12, 2019

@dnfclas

This comment has been minimized.

Copy link

dnfclas commented Mar 12, 2019

CLA assistant check
All CLA requirements met.

@worldbeater

This comment has been minimized.

Copy link
Member

worldbeater commented Mar 12, 2019

Probably worth including a reference to ReactiveUI.Validation package into the main table with references to all ReactiveUI packages instead of creating a separate table.

Also, instead of copy-pasting docs from https://github.com/reactiveui/ReactiveUI.Validation it's better to reference them and only paste most interesting snippets that could attract new users, one per feature (e.g. ValidationRule+BindValidation). That example with view and view model with references to controls is really large :)

GitHub
Contribute to reactiveui/ReactiveUI.Validation development by creating an account on GitHub.
@glennawatson
Copy link
Contributor

glennawatson left a comment

Might be worth updating your git. For some reason the file has gone into LFS

@alexmartinezm

This comment has been minimized.

Copy link
Contributor Author

alexmartinezm commented Mar 13, 2019

Might be worth updating your git. For some reason the file has gone into LFS

I just updated it.

@glennawatson glennawatson merged commit 48aeebd into reactiveui:master Mar 13, 2019

1 check passed

license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.