Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: update version dependencies of xamarin samples #1987

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
3 participants
@glennawatson
Copy link
Contributor

glennawatson commented Mar 26, 2019

I am updating as per noted by the user in reactiveui/website#320

@glennawatson glennawatson requested a review from reactiveui/core-team as a code owner Mar 26, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #1987 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1987   +/-   ##
=======================================
  Coverage   58.14%   58.14%           
=======================================
  Files         120      120           
  Lines        4785     4785           
  Branches      690      690           
=======================================
  Hits         2782     2782           
  Misses       1827     1827           
  Partials      176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b0825e...01c4366. Read the comment docs.

@giusepe

This comment has been minimized.

Copy link
Member

giusepe commented Mar 26, 2019

Give me a few mins to check this please, I have tried this before and wasn't compiling on Mac.
It may be something in my environment (most likely) or something related to the toolchain.

@giusepe

This comment has been minimized.

Copy link
Member

giusepe commented Mar 27, 2019

Go on, merge it. It's all working :)

@worldbeater worldbeater merged commit 1562aaa into master Mar 27, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 8b0825e...01c4366
Details
codecov/project 58.14% remains the same compared to 8b0825e
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-update-xamarin-samples branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.