Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Update to UAP 10.0.17763.0 #1988

Merged
merged 7 commits into from Apr 20, 2019

Conversation

Projects
None yet
2 participants
@glennawatson
Copy link
Contributor

commented Mar 31, 2019

Update to UAP 10.0.17763.0
Now using the generic conditions for the csproj.
Update various nuget packages in the Directory.Build.Props

This allows us to compile under visual studio 2019 on azure devops.

@glennawatson glennawatson requested a review from reactiveui/core-team as a code owner Mar 31, 2019

@worldbeater

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Feels like analyzers changed the behavior of CA2213 check:

'ScheduledSubject<T>' contains field '_defaultObserverSub' that is of IDisposable type 'IDisposable', but it is never disposed. Change the Dispose method on 'ScheduledSubject<T>' to call Close or Dispose on this field.

Probably worth changing action to None or Warning:

<Rule Id="CA2213" Action="Error" />

@glennawatson

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

Seems to be a legitimate bug tbh so will likely fix the warnings/errors. I think before they were just checking you had a dispose method now they check to make sure you dispose the contents

@glennawatson glennawatson requested review from reactiveui/android-team as code owners Apr 20, 2019

glennawatson added some commits Apr 20, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 20, 2019

Codecov Report

Merging #1988 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1988      +/-   ##
==========================================
- Coverage   58.14%   58.08%   -0.06%     
==========================================
  Files         120      120              
  Lines        4785     4786       +1     
  Branches      690      691       +1     
==========================================
- Hits         2782     2780       -2     
- Misses       1827     1830       +3     
  Partials      176      176
Impacted Files Coverage Δ
...activeUI/Platforms/uap/ActivationForViewFetcher.cs 0% <ø> (ø)
...forms/uap/DependencyObjectObservableForProperty.cs 0% <ø> (ø)
src/ReactiveUI.Blend/Platforms/uap/Behavior.cs 0% <ø> (ø)
src/ReactiveUI/Platforms/uap/WinRTAppDataDriver.cs 0% <ø> (ø)
src/ReactiveUI/Platforms/uap/AutoSuspendHelper.cs 0% <ø> (ø)
...I.Blend/Platforms/uap/ObservableTriggerBehavior.cs 0% <ø> (ø)
src/ReactiveUI/Scheduler/ScheduledSubject.cs 96.96% <0%> (-3.04%) ⬇️
src/ReactiveUI.Winforms/ViewModelViewHost.cs 89.32% <0%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f29899...513969d. Read the comment docs.

@glennawatson glennawatson requested review from reactiveui/uwp-team as code owners Apr 20, 2019

@glennawatson glennawatson changed the title housekeeping: Update nuget package versions housekeeping: Update to UAP 10.0.17763.0 Apr 20, 2019

@glennawatson glennawatson merged commit 1964338 into master Apr 20, 2019

4 of 6 checks passed

codecov/patch 0% of diff hit (target 58.14%)
Details
codecov/project 58.08% (-0.06%) compared to 8f29899
Details
ReactiveUI-CI Build #9.13.7+4be77670ad succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-update-nuget branch Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.