Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Use global ReactiveUI issue and PR templates #1989

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
3 participants
@worldbeater
Copy link
Member

commented Apr 1, 2019

What kind of change does this PR introduce?

GitHub templates update.

What is the current behavior?

ReactiveUI main repository uses locally stored issue/pr templates although we have global ones living at reactiveui/.github repository and they've been updated recently — in that update tips and descriptions were commented out, so folks still see them but don't have to delete manually.

What is the new behavior?

ReactiveUI repo now uses global issue and pull request templates.

What might this PR break?

Nothing.

@worldbeater worldbeater requested a review from reactiveui/learning-team Apr 1, 2019

@ghuntley ghuntley merged commit 12f2b8d into reactiveui:master Apr 1, 2019

4 checks passed

ReactiveUI-CI Build #9.12.12+d9bf6a9892 succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
license/cla All CLA requirements met.
Details
@glennawatson

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

Going to revert this back. The rxui ones had the specific rxui stack overflow links.

@glennawatson

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

The other smaller projects were the plan for the global templates.

@glennawatson

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

After talking to @worldbeater will keep the removed PR template since that's got no stack overflow information on it. Just will have the bug/feature templates until github introduces a macro for the template language or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.