Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
housekeeping: Added ReactiveUI.Splat.Tests #1991
What kind of change does this PR introduce?
Added Splat Adapter tests to wrap up reactiveui/splat#287
What is the current behavior?
There is no test coverage.
What is the new behavior?
ReactiveUI platform registration is tested against Splat adapters
What might this PR break?
Please check if the PR fulfills these requirements
@@ Coverage Diff @@ ## master #1991 +/- ## ======================================= Coverage 58.14% 58.14% ======================================= Files 120 120 Lines 4785 4785 Branches 690 690 ======================================= Hits 2782 2782 Misses 1827 1827 Partials 176 176
Apr 4, 2019
6 checks passed
In case anyone is curious why the code coverage stats didn't change it's because we only do code coverage on DLLs with reactiveui in the name. These tests don't add any extra coverage to ReactiveUI but are tests originally in the splat project and are very coupled with Reactiveui directly. We don't want to add splat to the coverage otherwise we'd have to cover all of splat in our unit tests.