Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Added ReactiveUI.Splat.Tests #1991

Merged
merged 2 commits into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@RLittlesII
Copy link
Member

commented Apr 4, 2019

What kind of change does this PR introduce?

Added Splat Adapter tests to wrap up reactiveui/splat#287

What is the current behavior?

There is no test coverage.

What is the new behavior?

ReactiveUI platform registration is tested against Splat adapters

What might this PR break?

Nothing

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@RLittlesII RLittlesII requested review from reactiveui/core-team as code owners Apr 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 4, 2019

Codecov Report

Merging #1991 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1991   +/-   ##
=======================================
  Coverage   58.14%   58.14%           
=======================================
  Files         120      120           
  Lines        4785     4785           
  Branches      690      690           
=======================================
  Hits         2782     2782           
  Misses       1827     1827           
  Partials      176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a180e...ec1c033. Read the comment docs.

@glennawatson glennawatson merged commit 1573e1f into master Apr 4, 2019

6 checks passed

ReactiveUI-CI Build #9.12.15+c47557b5bb succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
codecov/patch Coverage not affected when comparing 87a180e...ec1c033
Details
codecov/project 58.14% remains the same compared to 87a180e
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the splat branch Apr 4, 2019

@glennawatson

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

In case anyone is curious why the code coverage stats didn't change it's because we only do code coverage on DLLs with reactiveui in the name. These tests don't add any extra coverage to ReactiveUI but are tests originally in the splat project and are very coupled with Reactiveui directly. We don't want to add splat to the coverage otherwise we'd have to cover all of splat in our unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.