Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for DisableAnimation attribute before PopToRootAsync #2000

Merged
merged 2 commits into from Apr 11, 2019

Conversation

Projects
None yet
4 participants
@modplug
Copy link
Contributor

commented Apr 11, 2019

What kind of change does this PR introduce?
Bug Fix for Xamarin Forms

What is the current behavior?
It defaults to animate the transition even if the user has specified the [DisableAnimation] attribute.

What is the new behavior?
It checks whether the user has disabled animation or not

What might this PR break?
PopToRoot functionality on Xamarin Forms

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@modplug modplug requested a review from reactiveui/xamarin-forms-team as a code owner Apr 11, 2019

@glennawatson

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

Looks like there are some analyzer errors there.

RoutedViewHost.cs(107,26): error SA1513: Closing brace should be followed by blank line [D:\a\1\s\src\ReactiveUI.XamForms\ReactiveUI.XamForms.csproj]

@dnfclas

This comment has been minimized.

Copy link

commented Apr 11, 2019

CLA assistant check
All CLA requirements met.

@glennawatson glennawatson merged commit 5668476 into reactiveui:master Apr 11, 2019

1 check passed

license/cla All CLA requirements met.
Details
@glennawatson

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

I will do another release over the weekend and include this and another feature in. Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.